Branch: master

3c8aaa46 2016-09-05 17:45:54 Timothy Pearson
Fix display of unknown attributes in device manager details dialog
M kcontrol/hwmanager/devicepropsdlg.cpp
M kcontrol/hwmanager/devicepropsdlgbase.ui
diff --git a/kcontrol/hwmanager/devicepropsdlg.cpp b/kcontrol/hwmanager/devicepropsdlg.cpp
index e4eb87a..60dc864 100644
--- a/kcontrol/hwmanager/devicepropsdlg.cpp
+++ b/kcontrol/hwmanager/devicepropsdlg.cpp
@@ -363,17 +363,21 @@
 	return (TDEEventDevice::friendlySwitchList(switches).join("<br>"));
 }
 
+static TQString formatDisplayString(TQString input) {
+	return TQStyleSheet::escape(input);
+}
+
 void DevicePropertiesDialog::populateDeviceInformation() {
 	if (m_device) {
 		base->labelDeviceType->setText(m_device->friendlyDeviceType());
 		base->iconDeviceType->setPixmap(m_device->icon(TDEIcon::SizeSmall));
-		base->labelDeviceName->setText(m_device->friendlyName());
-		base->labelDeviceNode->setText((m_device->deviceNode().isNull())?i18n("<none>"):m_device->deviceNode());
-		base->labelSystemPath->setText(m_device->systemPath());
-		base->labelSubsytemType->setText(m_device->subsystem());
-		base->labelDeviceDriver->setText((m_device->deviceDriver().isNull())?i18n("<none>"):m_device->deviceDriver());
-		base->labelDeviceClass->setText((m_device->PCIClass().isNull())?i18n("<n/a>"):m_device->PCIClass());
-		base->labelModalias->setText((m_device->moduleAlias().isNull())?i18n("<none>"):m_device->moduleAlias());
+		base->labelDeviceName->setText(formatDisplayString(m_device->friendlyName()));
+		base->labelDeviceNode->setText(formatDisplayString((m_device->deviceNode().isNull())?i18n("<none>"):m_device->deviceNode()));
+		base->labelSystemPath->setText(formatDisplayString(m_device->systemPath()));
+		base->labelSubsytemType->setText(formatDisplayString(m_device->subsystem()));
+		base->labelDeviceDriver->setText(formatDisplayString((m_device->deviceDriver().isNull())?i18n("<none>"):m_device->deviceDriver()));
+		base->labelDeviceClass->setText(formatDisplayString((m_device->PCIClass().isNull())?i18n("<n/a>"):m_device->PCIClass()));
+		base->labelModalias->setText(formatDisplayString((m_device->moduleAlias().isNull())?i18n("<none>"):m_device->moduleAlias()));
 
 		// These might be redundant
 		#if 0
@@ -385,7 +389,7 @@
 		base->labelVendorModel->hide();
 		base->stocklabelVendorModel->hide();
 		#endif
-		base->labelSerialNumber->setText((m_device->serialNumber().isNull())?i18n("<unknown>"):m_device->serialNumber());
+		base->labelSerialNumber->setText(formatDisplayString((m_device->serialNumber().isNull())?i18n("<unknown>"):m_device->serialNumber()));
 
 		if (m_device->subsystem() == "pci") {
 			base->labelBusID->setText(m_device->busID());
@@ -402,15 +406,15 @@
 
 			TQString mountPoint = sdevice->mountPath();
 			if (mountPoint == "") mountPoint = i18n("<none>");
-			base->labelDiskMountpoint->setText(mountPoint);
+			base->labelDiskMountpoint->setText(formatDisplayString(mountPoint));
 
 			TQString fsName = sdevice->fileSystemName();
 			if (fsName == "") fsName = i18n("<unknown>");
-			base->labelDiskFileSystemType->setText(fsName);
+			base->labelDiskFileSystemType->setText(formatDisplayString(fsName));
 
 			TQString volUUID = sdevice->diskUUID();
 			if (volUUID == "") volUUID = i18n("<none>");
-			base->labelDiskUUID->setText(volUUID);
+			base->labelDiskUUID->setText(formatDisplayString(volUUID));
 
 			// Show status
 			TQString status_text = "<qt>";
diff --git a/kcontrol/hwmanager/devicepropsdlgbase.ui b/kcontrol/hwmanager/devicepropsdlgbase.ui
index 504c5ac..0ea911c 100644
--- a/kcontrol/hwmanager/devicepropsdlgbase.ui
+++ b/kcontrol/hwmanager/devicepropsdlgbase.ui
@@ -50,7 +50,7 @@
 						<cstring>iconDeviceType</cstring>
 					</property>
                     		</widget>
-				<widget class="KActiveLabel" row="0" column="2" colspan="1">
+				<widget class="TQLabel" row="0" column="2" colspan="1">
 					<property name="name">
 						<cstring>labelDeviceType</cstring>
 					</property>